Skip to content
This repository has been archived by the owner on Apr 25, 2021. It is now read-only.

Wip/windows jansi fixes #47

Merged
merged 9 commits into from
Jun 29, 2013
Merged

Wip/windows jansi fixes #47

merged 9 commits into from
Jun 29, 2013

Conversation

jsuereth
Copy link
Member

Fixes jline terminal issues at the sacrifice of ansi colors.

  • Unify all jline/ansi code on what the sbt launcher does by default (push all issues down to core)
  • Temporarily use stty hacks for cygwin, hopefully we can dig in further into the issue
  • backspace now broken in in cygwin -> sbt -> scala console. Looking fora fix there, but better than not working at all.

QUick review by @harrah

@jsuereth
Cleanup of launcher package to remove special casing of
bec43f0 
JANSI.  This, hopefully, will lead to better compatibility
between the many console-enrichment projects, like:
JLINE-scala, JLINE-1.0, JLINE-2.0 and Jansi itself.

Testing to ensue shortly between 0.12.x + 0.13.x
@jsuereth
Fixes to scripts for working in both cygwin and cmd.exe.
3b9519b 
THis basically moves from jline.UnixTerminal to just unix.
@jsuereth jsuereth mentioned this pull request Jun 17, 2013
Closed
@jsuereth
Copy link
Member Author

It appears to be an issue with jline 2.0 vs. jline 1.0. THe old jline
required a full class name, while the new jline does not. I see migration
woes in our future, we may need to try to get a patch into jline 2.0

On Tue, Jun 18, 2013 at 9:07 AM, mbrambley notifications@github.com wrote:

hi there thanks for trying to sort this - i get this when i use your sbt:
[error] java.lang.IllegalArgumentException:
java.lang.ClassNotFoundException: unix
[error] Use 'last' for the full log.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-19609706
.

@jsuereth
Modify script for new 0.13 behavior.
360428a
@jsuereth
Upgrade to in-progress sbt-native-packager plugin, including new supp…
a99f6ff 
…ort for universal->debian/rpm packages.
@jsuereth
Fixed up MSI generation for new layout. MinGW tests to follow.
b531a82
@jsuereth
Migrating to new native packaging plugin abstractions.
53f9de2 
* Use new native packaging abstractions for windows mappings.
* Update universal sbt script to be cygwin friendly
* Modify sbt.bat for universal layout
* Fix some stty icanon (no)echo bugs in launcher script.
@jsuereth
Migrate universal windows scripts into universal directory.
d16ab1a 
ALso, added back the commented sbtopts settings.
@jsuereth
Fix config file loading to do shell expansion first.
1835225 
from @benevans.
@jsuereth
Merge remote-tracking branch 'origin/full-packaging' into wip/windows…
2af99ce 
…-jansi-fixes
@jsuereth
Copy link
Member Author

Ok, after extensive platform testing, this appears to be ready to roll.

jsuereth added a commit that referenced this pull request Jun 29, 2013
@jsuereth
Merge pull request #47 from sbt/wip/windows-jansi-fixes
e597210 
Wip/windows jansi fixes
@jsuereth jsuereth merged commit e597210 into full-packaging Jun 29, 2013
@jsuereth jsuereth deleted the wip/windows-jansi-fixes branch June 29, 2013 14:29
jiminhsieh pushed a commit to jiminhsieh/sbt-launcher-package that referenced this pull request Jul 19, 2018
@eed3si9n
Merge pull request sbt#47 from eed3si9n/topic/library-loader
200eeff 
Layered class loading of library and compiler
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jsuereth