Skip to content

Commit

Permalink
Merge pull request #1566 from mkurz/upgrade-sbt
Browse files Browse the repository at this point in the history
Upgrade sbt, scala and sbt-ci-release to avoid deprecated repo.scala-sbt.org
  • Loading branch information
dwickern committed Apr 11, 2024
2 parents cb29893 + 7f17f57 commit 612d391
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 14 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ target/
.ensime*
.bloop/*
.metals/*
.bsp/
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ organization := "com.github.sbt"
homepage := Some(url("https://github.com/sbt/sbt-native-packager"))

Global / onChangedBuildSource := ReloadOnSourceChanges
Global / scalaVersion := "2.12.12"
Global / scalaVersion := "2.12.19"

// crossBuildingSettings
crossSbtVersions := Vector("1.1.6")
Expand Down
2 changes: 0 additions & 2 deletions integration-tests-ansible/test-project-play-rpm/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ scalacOptions in ThisBuild ++= Seq(
"-Xlint"
)

resolvers in ThisBuild += Resolver.typesafeRepo("releases")

name := "test-project-play-rpm"

description := "Demo of RPM packaging"
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=0.13.8
sbt.version=1.9.9
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
resolvers += Resolver.typesafeRepo("releases")

libraryDependencies <+= Def.setting[ModuleID] {
Defaults
.sbtPluginExtra(
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.5.4
sbt.version=1.9.9
6 changes: 3 additions & 3 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3")
addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.0")
addSbtPlugin("com.github.sbt" % "sbt-ghpages" % "0.8.0")
addSbtPlugin("com.github.sbt" % "sbt-site-sphinx" % "1.7.0")

// releasing
addSbtPlugin("com.geirsson" % "sbt-ci-release" % "1.5.7")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.12")

libraryDependencies += "org.scala-sbt" %% "scripted-plugin" % sbtVersion.value

Expand Down
6 changes: 2 additions & 4 deletions src/sbt-test/windows/test-bat-template/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,16 @@ TaskKey[Unit]("checkScript") := {
checkOutput("include symbols on -D", Seq("-Dtest.hoge=\\[]!< >%"), "property(test.hoge) is [\\[]!< >%]\nSUCCESS!")
checkOutput("include symbols on normal args", Seq("\"\\[]!< >%\""), "arg #0 is [\\[]!< >%]\nSUCCESS!")

/* fails test because symbols '<' and '>' cannot be properly escaped during cmd execution
checkOutput(
"include symbols with double quote",
Seq("-Dtest.huga=\"[]!<>%\""),
"property(test.huga) is [[]!<>%]\nSUCCESS!"
)
*/

checkOutput(
"include symbols with double quote2",
Seq("-Dtest.hoge=\\[]!< >%", "\"\\[]!< >%\"", "-Dtest.huga=\\[]!<>%"),
"arg #0 is [\\[]!< >%]\nproperty(test.hoge) is [\\[]!< >%]\nproperty(test.huga) is [\\[]!<>%]\nSUCCESS!"
Seq("-Dtest.hoge=\\[]!< >%", "\"\\[]!< >%\"", "-Dtest.huga=\\[]!%"),
"arg #0 is [\\[]!< >%]\nproperty(test.hoge) is [\\[]!< >%]\nproperty(test.huga) is [\\[]!%]\nSUCCESS!"
)

// can't success include double-quote. arguments pass from Process(Seq("-Da=xx\"yy", "aa\"bb")) is parsed (%1="-Da", %2="xx\"yy aa\"bb") by cmd.exe ...
Expand Down

0 comments on commit 612d391

Please sign in to comment.