Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't hard-code xz compression option "-9e". If compression level was…
…n't hard-coded in the xz command-line used by SBT, the user would be able to set the desired compression options via environment variable XZ_OPT. But, currently, since "-9e" is hard-coded, (#1430) the options in XZ_OPT will always be overwritten! Also "-9e" is *not* a good default to begin with. Level "-9" is very slow and needs a whole lot memory (can cause OOM killer to kill your build process!) for probably only a little improvement in compression ratio. Furthermore, option "-e" easily doubles compression time for marginal improvement in compression ratio (if at all); that's really something you'd use if don't care about compression time at all. IMHO it really makes much more sense to just use the xz defaults and let the user override them, via XZ_OPT environment variable, if desired. Form the xz manpage: - "Unless you want to maximize the compression ratio, you probably don't want a higher preset level than -7 due to speed and memory usage." - On the '-e' option: "Modify the compression preset (-0 ... -9) so that a little bit better compression ratio can be achieved without increasing memory usage of the compressor or decompressor. The downside is that the compression time will increase dramatically (it can easily double)." https://linux.die.net/man/1/xz Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com>
- Loading branch information