Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove carriage return characters when loading configuration files. #1074

Closed
JustinPihony opened this issue Nov 29, 2017 · 1 comment
Closed
Labels
bug universal Zip, tar.gz, tgz and bash issues

Comments

@JustinPihony
Copy link
Contributor

This is to mimic sbt/sbt-launcher-package#166 Without the fix the following yields Invalid initial heap size: -Xms512M

javaOptions in Universal ++= Seq(
"-J-Xms512M",
"-J-Xmx2G",
"-J-server" 
)

Expected behaviour

Do not throw exception

Actual behaviour

Invalid initial heap size: -Xms512M
Error: Could not create the Java Virtual Machine
Error: A fatal exception has occurred. Program will exit.

Information

https://github.com/sbt/sbt-native-packager/blob/master/src/main/resources/com/typesafe/sbt/packager/archetypes/scripts/bash-template#L266 should be

cat "$1" | sed '/^\#/d;s/\r$//'

@muuki88
Copy link
Contributor

muuki88 commented Dec 10, 2017

Thanks a lot for your detailed bug report :) Sorry for replying so late.

Would you like to provide this fix as a pull request?

@muuki88 muuki88 added bug universal Zip, tar.gz, tgz and bash issues labels Dec 10, 2017
JustinPihony added a commit to JustinPihony/sbt-native-packager that referenced this issue Dec 13, 2017
muuki88 pushed a commit that referenced this issue Dec 13, 2017
…1078)

* Remove carriage return characters when loading configuration files.

Fixes #1074

* Also fix ash-template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Development

No branches or pull requests

2 participants