Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't (correctly) generate a deb with a file in /etc/sudoers.d #394

Open
fhars opened this issue Oct 27, 2014 · 7 comments
Open

Can't (correctly) generate a deb with a file in /etc/sudoers.d #394

fhars opened this issue Oct 27, 2014 · 7 comments
Projects

Comments

@fhars
Copy link

fhars commented Oct 27, 2014

When you try to generate a deb with a file in /etc/sudoers.d, you can choose between a lintian error bad-perm-for-file-in-etc-sudoers.d 0660 != 0440, or generate the file with the expected withPerms "0440" and have the second build fail with a (misleading) java.io.FileNotFoundException: ... (Permission denied). Looks like the target directory gets reused without cleanup between builds.

@fhars fhars changed the title Can't (correctly) generate a deb with a file in /etc/sudoers.s Can't (correctly) generate a deb with a file in /etc/sudoers.d Oct 27, 2014
@muuki88
Copy link
Contributor

muuki88 commented Nov 13, 2014

Can you provide a small sample project? I couldn't reproduce the error.
I wrote a test for the current master branch.

muuki88 added a commit that referenced this issue Nov 15, 2014
FIX #394 adding tests for native packaging with 0440 permissions
@fhars
Copy link
Author

fhars commented Nov 25, 2014

The test does not address the problem at hand. Try adding a second

> debian:packageBin

line to see the problem.

@muuki88
Copy link
Contributor

muuki88 commented Nov 25, 2014

So the actual problem that you can't run debian:packageBin twice in a row without a clean in between?

Looks like the target directory gets reused without cleanup between builds

That's the case. So this is rather a performance issue, as clean wipes out your complete target directory and you have to recompile everything. However IMHO the bug itself is not a big deal, as you build debians for releases/snapshots and putting a clean upfront is always a good idea to avoid a messy target directory.

@kardapoltsev
Copy link
Member

Our target dir need to be refactored I think. Now it seems quite messy and unstructured. Also, cleaning this directory (not whole target) before creating package is a good idea IMHO (I've got some bugs with this).
WDYT @muuki88 ?

@muuki88
Copy link
Contributor

muuki88 commented Mar 30, 2015

@kardapoltsev you mean the created debian target directory structure? What particularly do you mean? I think the code base could always use a bit of a facelifting (there are too many debian related parts spread in the code base).

Cleaning target in Debian before each packaging sounds good to me.

@kardapoltsev
Copy link
Member

Yes, I mean dir structure created during packaging in target.

@muuki88
Copy link
Contributor

muuki88 commented Mar 30, 2015

IMHO the messy part is where all the bin, configure scripts are placed :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants