Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packageName in Docker has no effect #947

Closed
asarkar opened this issue Mar 12, 2017 · 5 comments
Closed

packageName in Docker has no effect #947

asarkar opened this issue Mar 12, 2017 · 5 comments

Comments

@asarkar
Copy link

asarkar commented Mar 12, 2017

I've a multimodule project where each module creates a Docker image. I'd like to customize the image name but the following statement has no effect. The image names are still taken from the project names.

packageName in Docker := "ufo-sightings-" + name.value

Image names:

REPOSITORY              TAG                 IMAGE ID            CREATED             SIZE
asarkar/consumer        1.0-SNAPSHOT        8cebb22ff45f        10 minutes ago      393 MB
asarkar/producer        1.0-SNAPSHOT        1684ac156186        45 minutes ago      198 MB
@muuki88
Copy link
Contributor

muuki88 commented Mar 12, 2017

Thanks @asarkar for you report. This seems to be a bug.

This line doesn't scope the packageName setting correcty.

It should be

dockerAlias := DockerAlias(dockerRepository.value, None, (packageName in Docker).value, Some((version in Docker).value))

Would you like to open a PR to fix this?

@asarkar
Copy link
Author

asarkar commented Mar 12, 2017

@muuki88 I'm just a basic SBT user and also working on other things. I think I'll leave it to the maintainers to fix this issue. Based on your comment, it appears to be a simple fix.

Meanwhile, I suppose the workaround is to define the dockerAlias. Is that right?

@muuki88
Copy link
Contributor

muuki88 commented Mar 15, 2017

@asarkar no problem :)

Yes, defining your own alias is the way. Sorry that I kept that a bit vague.

@asarkar
Copy link
Author

asarkar commented Mar 16, 2017

@muuki88 Thanks. Which version is this fix going to be available in?

@muuki88
Copy link
Contributor

muuki88 commented Mar 18, 2017

In the next 1.2.x milestone release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants