Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM with killtimeout #957

Closed
mr-git opened this issue Apr 7, 2017 · 5 comments
Closed

RPM with killtimeout #957

mr-git opened this issue Apr 7, 2017 · 5 comments

Comments

@mr-git
Copy link
Contributor

mr-git commented Apr 7, 2017

SBT: 0.13.13
Server OS: Centos 7.2.x
Development OS: macOS 10.12.4
Scala: 2.11.8
Version: 1.2.0-M8
RPM: 4.8.0

I am trying to use killTimeout (http://www.scala-sbt.org/sbt-native-packager/archetypes/systemloaders.html?highlight=killtimeout) feature to delay the server killing, but I cannot get it done.

Related parts in code are:

    override def requires: Plugins = RpmPlugin && JavaServerAppPackaging && BashStartScriptPlugin && SystemVPlugin
//...
    killTimeout in Linux := 153, 
//...

I expected that this will add the value somewhere in startup scripts, but I cannot find them in locally generated RPM buildroot.

Am I missing something or am I doing something wrongly?

Thanks!

@muuki88 muuki88 added the rpm label Apr 7, 2017
@muuki88
Copy link
Contributor

muuki88 commented Apr 7, 2017

Have you activated any kind of systemloader plugin? For RPM you normally use the SystemVPlugin or SystemdPlugin.

@mr-git
Copy link
Contributor Author

mr-git commented Apr 9, 2017

Doh.. the github issues do not like to have backticks and first line of code on same line.

override def requires: Plugins = RpmPlugin && JavaServerAppPackaging && BashStartScriptPlugin && SystemVPlugin

This is the line of enabled plugins

@mr-git
Copy link
Contributor Author

mr-git commented Apr 10, 2017

The expected result would be to have -d <seconds> parameter added to killproc command in init script, but in generated code I see only this:

stop() {
    echo -n $"Stopping $prog: "
    killproc -p $PIDFILE $prog
    retval=$?
    echo
    [ $retval -eq 0 ] && rm -f $lockfile
}

@mr-git
Copy link
Contributor Author

mr-git commented Apr 10, 2017

- seems that here it is missing

@muuki88
Copy link
Contributor

muuki88 commented Apr 10, 2017

Thanks for the resarch @mr-git
The systemv rpm startup script doesn't implement this feature. Only the systemv debian script does.

Would you like to a open a pull request for this?

muuki88 pushed a commit that referenced this issue Apr 11, 2017
* #957 RPM with `killTimeout`

* #957 replace tabs with spaces

* #957 replace tabs with spaces

* #957 `rpmbuild` wants to have the `rpmGroup`
@muuki88 muuki88 added this to Feature Requests in Rpm May 25, 2017
@muuki88 muuki88 closed this as completed May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rpm
Feature Requests
Development

No branches or pull requests

2 participants