Refresh PR: Treat symlinks as normal files in spec file #1039
Conversation
|
Hi @erickpintor, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
erickpintor
force-pushed
the
rpm-symlinks
branch
from
d8cc54a
to
d7d985b
Compare
|
I will be offline for 3 weeks ( traveling through New Zealand ), but will review and merge these changes as soon as I am back home. Thanks for the very quick response and your time working on native-packager 😍😍 |
|
Sure. No problem. I've noticed some broken tests on Travis that might be caused by this PR. I'll take a look at them next week since I'll be also traveling. I also signed the Lightbend Contributors License Agreement. Enjoy your vacation. |
|
Thanks for resurrecting this. A series of life events has prevented me from doing so. |
erickpintor
force-pushed
the
rpm-symlinks
branch
from
d7d985b
to
11c15ed
Compare
|
Hi everyone. I fixed the failing test that was caused by this PR. There are still 2 failing tests suites: bash and ash. I think there were already broken before and they don't seem to be related to this PR. Anyway, let me know if there is anything else to change / improve. |
|
Awesome 😎 I'll take a look as soon as I'm home ( 22.10 ) |
I'm trying to bring back to life a very old PR: #916
Here I'm adding back the original test made by @dpennell and I'm reapplying his changes on top of the current master branch.
An interesting improvement is that by describing symbolic links as part of RPM's spec file, it can remove them during uninstall, leaving no empty folders behind. Previously, the links were removed in the
postunhook, after RPM tried to rid of its managed folders, resulting in empty directories whenever there was a symbolic link inside them.I've tested this with a project I'm working on using a CentOS VM.