Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included feature publishM2 #1113

Merged
merged 4 commits into from
Apr 1, 2018
Merged

Included feature publishM2 #1113

merged 4 commits into from
Apr 1, 2018

Conversation

giorgioinf
Copy link
Contributor

Feature request - publishM2

It's a small change including a publishM2 action. Currently the sbt-native-packages only supportspublish and publishLocal actions.

Tested on

  • O.S.: MacOSX, Darwin 17.4.0 Darwin Kernel Version 17.4.0: Sun Dec 17 09:19:54 PST 2017; root:xnu-4570.41.2~1/RELEASE_X86_64 x86_64
  • bash: GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin17)
  • sbt: 1.1.1
  • scala: Scala code runner version 2.12.5 -- Copyright 2002-2018, LAMP/EPFL and Lightbend, Inc
  • java jdk: java version "1.8.0_162",Java(TM) SE Runtime Environment (build 1.8.0_162-b12), Java HotSpot(TM) 64-Bit Server VM (build 25.162-b12, mixed mode)

@lightbend-cla-validator

Hi @giorgioinf,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@giorgioinf
Copy link
Contributor Author

Issue: #1114

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid pull request 😎

Thanks for improving sbt-native-packer. This looks like a reasonable extension. We'll merge when the tests have passed.

@giorgioinf
Copy link
Contributor Author

giorgioinf commented Mar 28, 2018

How can we deal with this travis error at .m2 directory, when it is building a package at second time?

[info] [error] java.io.IOException: Destination file file:/home/travis/.m2/repository/simple-test/simple-test/0.1.0/simple-test-0.1.0.zip exists and overwrite == false

Similar problem:

https://stackoverflow.com/questions/26077419/how-to-overwrite-local-stable-version-artifacts-using-publishlocal#26089552

Workaround:

add isSnapshot in ThisBuild := true

or

change version := "0.1.0" to version := "0.1.0-SNAPSHOT"

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Mar 30, 2018
@muuki88
Copy link
Contributor

muuki88 commented Mar 30, 2018

Sorry for my last (now deleted) comment. I haven't seen your last comment, which already addressed this issue.

I would go isSnapshot in ThisBuild := true and put a small comment in there why we need it.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😍

@muuki88 muuki88 merged commit fdbf59c into sbt:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants