Better upstart script

[dbathily]

Add a stop stanzas (http://upstart.ubuntu.com/cookbook/#job-with-start-on-but-no-stop-on) and use start-stop-daemon as recommended in the upstart cookbook (http://upstart.ubuntu.com/cookbook/#changing-user)

Some server applications (like those builded with play framework) will not launch after a reboot/shutdown without a proper stop because they create a pid file and don't boot if this file exists. For those applications, a stop before system's shutdown is mandatory.

Also, for those applications, we can improve the script by adding a "pre start" Stanzas that will delete the pid file if it exist and if there haven't a running process with the corresponding id. That's why I think the feature #118 will be useful. Playframework will provide his upstart script.

[lightbend-cla-validator]

Hi @dbathily,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

[dbathily]

Done

[aparkinson]

Nice!

[aparkinson]

By default Java processes aren't daemonized and you would have to use start-stop-daemon or Apache Daemon to do it. Upstart is designed so you don't have to daemonize processes:

'Upstart will keep track of the process ID that it thinks belongs to a job. If a job has specified the instance stanza, Upstart will track the PIDs for each unique instance of that job.' [1]

'If your daemon has a "don't daemonize" or "run in the foreground" mode, then it's much simpler to use that and not run with fork following. One issue with that though, is that Upstart will emit the started JOB=yourjob event as soon as it has executed your daemon, which may be before it has had time to listen for incoming connections or fully initialize.' [1]

[1] http://upstart.ubuntu.com/cookbook/#expect

[dbathily]

Keep only the stop Stanzas?

[muuki88]

IMHO we should keep the stop stanza ( I ran into the same issue like you ).
However the other peace of code may be of interest for people with legacy systems ( are there that many @jsuereth ? )

A small hint in the documentation/Readme ( especially how it works with play ) would be awesome too.
I try to work on #98 next week, so it should be easier to append Java_opts.

[jsuereth]

Haven't really decided on a support policy. For Ubuntu, I think the default should support the last LTS release. Anything past that is "gravy" (if it's easy, good, but otherwise folks using older Ubuntu could provide their own upstart scripts, as they would have had to before this plugin).

Also, thanks much for this patch! I'll be looking into it and doing a milestone release for this plugin on monday.

[muuki88]

@dbathily can make the change, so only the

# When to stop the service
stop on runlevel [016]

remains. The rest could be discussed in another ticket/pull request.

[dbathily]

Done ;)

[muuki88]

Thanks :-)

[jsuereth]

Looks great! Thanks.