Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Graalvm docker repository & build version #1395

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

kgston
Copy link
Contributor

@kgston kgston commented Jan 25, 2021

Closes #1394.

For some reason, the native-image binary is not able to find the Main class... when running sbt scripted graalvm-native-image/*
Didn't look too deep into the cause yet.

@lightbend-cla-validator

Hi @kgston,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@muuki88 muuki88 added docker minor release drafter version graalvm GraalVM releated issues and removed docker labels Jan 25, 2021
muuki88
muuki88 previously approved these changes Jan 25, 2021
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if the test fails on my machine. CI seems good.

@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2021

I assume this due to graalvm 19.0.0 used for the CI tests.

java-version: graalvm@19.0.0

@kgston
Copy link
Contributor Author

kgston commented Jan 26, 2021

I assume this due to graalvm 19.0.0 used for the CI tests.

java-version: graalvm@19.0.0

I can update that to the latest version and see if that changes anything. But I think that only affects the "local" Graalvm compile test and not the docker compile test

@kgston
Copy link
Contributor Author

kgston commented Jan 26, 2021

Seems like the Java repo the Github action is trying to pull from only has up to 20.3.0 at this time. 🤔
It is waiting on this PR: shyiko/jabba#765

@muuki88
Copy link
Contributor

muuki88 commented Jan 26, 2021

Noice. The GitHub UI is really a breeze to use.

@kgston
Copy link
Contributor Author

kgston commented Feb 25, 2021

Graalvm 21.0.0 has been released on Jabba, any chance we can merge this fix in? The CI checks seem to pass, so I assume that the test that is failing locally for me has to do with some local config I might be missing.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍😎

@muuki88 muuki88 merged commit efe7c7a into sbt:master Feb 25, 2021
@kgston kgston deleted the fix-graalvm-docker-build branch February 26, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graalvm GraalVM releated issues minor release drafter version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graalvm docker image repository no longer hosted at docker hub
3 participants