DockerPlugin code cleanup

[frankivo]

Some preparations to work on #1417

[muuki88]

Thanks a lot for the cleanup, especially in a separate PR ❤️ And thanks for your patience.

Only one small change then this is good to merge 😃

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[frankivo]

Thanks a lot for the cleanup, especially in a separate PR ❤️ And thanks for your patience.

Only one small change then this is good to merge 😃

Applied the changes :)

I'm not quite sure what the lightbend-cla-validator is on about.
Well, I guess I understand it. Just not sure how to resolve it, yet.

[frankivo]

I feel like the best solution is to recreate those commits + pr?

[frankivo]

I'll be traveling as of Thursday. If you can find a way to merge this, please do :)

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[muuki88]

Sorry for the delay. Had a rough week ( lower back pain ) 😅

Can you run scalafmt for a correct formatting? Then this is good to go

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[frankivo]

@muuki88 ping

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[muuki88]

There are two compilation errors after updating to master and the CLA must be signed 🤗

[frankivo]

I'm confused, The error logs seems to be for scala 2.10 ?

[muuki88]

Sbt 0.13 is scala 2.10 and the plugin is still cross building

[lightbend-cla-validator]

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[frankivo]

Holy smokes, it happened.

[muuki88]

Thanks for your patience 💖

I try to act as fast as possible here, but family has higher priority 😊

[frankivo]

No worries. Didn't mean to be salty :)

[muuki88]

Not at all 🤗 Thanks anyway for being so considerate ☺️