Fix missing Graalvm native-image binary symlink in generated container image #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgston
force-pushed
the
fix-graalvm-image-native-image
branch
from
ef8ca9e
to
57b9926
Compare
kgston
force-pushed
the
fix-graalvm-image-native-image
branch
2 times, most recently
from
01703a8
to
e7fc4b9
Compare
muuki88
approved these changes
Feb 21, 2022
|
THanks @kgston for fixing this long standing issue ❤️ |
|
1.9.9 is on its way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1492
Solution based on the monkeypatch provided by pshirshov
I decided to use a wildcard interpolation to get the correct folder for the symlink since there will only be one version of graalvm in the image anyway and trying to derive it from
graalVMNativeImageGraalVersionwhich could contain variations on the base image version, would be difficult to parse accurately.Also updates the graalvm base image version in the tests to the latest, otherwise the existing test would report a false positive using the old version.