FIX #249. Systemd support for Debian and Rpm #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kardapoltsev
changed the title
|
@kardapoltsev can you update this pr for automatic merge? |
…systemd Conflicts: src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala
|
Is it fine to use such merge commits? |
|
IMHO smaller commits are better to handle. However this is a complete feature, so it's okay. |
|
Can you provide a small hint in the |
|
My english is bad, so could you check this notes about systemd? Should I add more detailed docs? |
| @@ -28,6 +28,17 @@ For the native packager keys add this to your `build.sbt` | |||
| import com.typesafe.sbt.SbtNativePackager._ | |||
| import NativePackagerKeys._ | |||
|
|
|||
| ## Experimental systemd bootsystem support ## | |||
|
|
|||
| Native packager have an experimental `systemd` bootsystem. | |||
There was a problem hiding this comment.
I would change this to
"Native packager now provides experimental systemd startup scripts"
|
Perfect! Just one comment and we are good to go |
|
Any more issues with this PR? |
muuki88
added a commit
that referenced
this pull request
May 26, 2014
FIX #249. Systemd support for Debian and Rpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works fine on
Fedora release 20 (Heisenbug)and I hope will work on Ubuntu when systemctl command will be added to Ubuntu release.Also systemd units are placed in Ubuntu in another directory rather than Fedora or Gentoo, so new config
defaultLinuxStartScriptLocationwas added.