Play backward compatibility issue

[huntc]

I've just tried using 1.0.0-M1 with Play and unfortunately it is not possible.

The first thing I've come across is that some APIs have become private e.g.:

https://github.com/sbt/sbt-native-packager/blob/master/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala#L111

Play actually uses the makeJarName function (there may be others, but I've not been able to progress beyond this issue so far).

I'm just wondering if we should re-visit what was made private - how concerned are we re. backward compatibility from an API perspective?

[huntc]

I've turned this issue into a PR.

I've also released sbt-native-packager as 1.0.0-d818400131a351f0b3b89680b688920f178344fc and tested it against Play 2.4.0-M1. All appears well.

[muuki88]

Thanks @huntc ! Well, I tried to make it as compatible as poosible. We shouldn't hurt our users, too much :/

[huntc]

Hey you've done a magnificent job re compatibility! This was the only api that I could find Play depending on. It may be worth thinking about some of those other methods that became private though; just in case other projects are using them. WDYT?

[muuki88]

Thanks :) Happy it worked out this good.

And yes, we could revisit the methods turning private. However I think there aren't a lot more. The deploymentSettings are currently re added in #389 and the rest got deprecated.