Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to specific directory for ADD command #458

Merged
merged 1 commit into from
Jan 8, 2015
Merged

Conversation

huntc
Copy link
Contributor

@huntc huntc commented Jan 8, 2015

PR #424 moved to a ADD wildcard approach, and then removed the Dockerfile. There were two problems with this:

  • ADD seems to behave weirdly regarding recursion. /opt/docker and /docker were both added to the output.
  • I had incorrectly set the current working directory to the parent of the context directory, where it really should be the context directory itself. This only worked because there was a Dockerfile in the parent also.

PR sbt#424 moved to a ADD wildcard approach, and then removed the Dockerfile. There were two problems with this:
* ADD seems to behave weirdly regarding recursion. /opt/docker and /docker were both added to the output.
* I had incorrectly set the current working directory to the parent of the context directory, where it really should be the context directory itself. This only worked because there was a Dockerfile in the parent also.
@huntc huntc added bug documentation Documentation should be extended or updated docker and removed documentation Documentation should be extended or updated labels Jan 8, 2015
@huntc huntc added this to the 1.0.0 Autoplugins milestone Jan 8, 2015
muuki88 added a commit that referenced this pull request Jan 8, 2015
Back to specific directory for ADD command
@muuki88 muuki88 merged commit e0968b5 into sbt:master Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants