Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for process to stop or timeout in systemv init script #462

Merged
merged 1 commit into from
Jan 16, 2015

Conversation

dhardy92
Copy link
Contributor

start-stop-dameons does not wait for service to stop before returning.
This may results in error on upgrade of the package trying to start the service while old version is still shutting down.

@lightbend-cla-validator

Hi @dhardy92,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

@muuki88 muuki88 added universal Zip, tar.gz, tgz and bash issues rpm debian and removed universal Zip, tar.gz, tgz and bash issues rpm labels Jan 14, 2015
@muuki88
Copy link
Contributor

muuki88 commented Jan 14, 2015

LGTM. On which system did you test this?
Ping here when you signed the CLA

@kardapoltsev
Copy link
Member

May be it'll be better to specify timeouts in configs? For some applications it could take long time for proper shutdown.

@dhardy92
Copy link
Contributor Author

@muuki88 I just signed it :

Thank you! Your submission was processed.

@dhardy92
Copy link
Contributor Author

@kardapoltsev I just push a proposition to use variables but as I don't know Scala (sysop here 😄 ) :
http://knowyourmeme.com/photos/234765-i-have-no-idea-what-im-doing

BTW tests pass

@kardapoltsev
Copy link
Member

LGTM. Thanks! Lets wait for travis (:

@muuki88
Copy link
Contributor

muuki88 commented Jan 14, 2015

Ah, good catch @kardapoltsev . @dhardy92 could you squash the commits? I'll try to backport this to 0.8.x

@dhardy92
Copy link
Contributor Author

squashed

@muuki88
Copy link
Contributor

muuki88 commented Jan 16, 2015

awesome. Thanks :)

muuki88 added a commit that referenced this pull request Jan 16, 2015
wait for process to stop or timeout in systemv init script
@muuki88 muuki88 merged commit 45bd546 into sbt:master Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants