[Fix #476] Fixing -jvm-debug flags so that they use args compatible with the latest JDKs #478
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est JDKs, instead of the outdated JDK 1.4 args
|
Hi @jateenjoshi, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
This change simply changes the -jvm-debug flag being passed through a bash script - there's no reason why this should fail a build - especially on a particular jdk8 build. Is this a known issue with the build? The jdk8 build seems to be unable to resolve: org.scala-lang#scala-actors;2.10.2!scala-actors.jar |
|
Travis sometimes fails. I retriggered the job. We don't have any tests that cover this, so everything is fine. thanks for your work :) |
|
Thanks, np :) |
muuki88
added a commit
that referenced
this pull request
Feb 4, 2015
[Fix #476] Fixing -jvm-debug flags so that they use args compatible with the latest JDKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing the -jvm-debug flag the sbt native packager's bash template currently passes the following jvm debug flags:
-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=[debug port]
This is outdated (it is for JVM 1.4.x) and for newer JVMs should be:
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=[debug port]