Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure systemd works with RPM relocatable packages #711

Merged
merged 1 commit into from
Dec 6, 2015

Conversation

fsat
Copy link
Collaborator

@fsat fsat commented Dec 3, 2015

Ensure correct installation path is being used in the service file required by systemd.

This is done by replacing the default installation path with the actual installation path
within the service file during install time of the RPM package.

Ensure correct installation path is being used in the service file required by systemd.

This is done by replacing the default installation path with the actual installation path
within the service file during install time of the RPM package.
@fsat
Copy link
Collaborator Author

fsat commented Dec 3, 2015

@muuki88 and @huntc - can I get a PR review on this please?

This fix will ensure systemd service file has the correct install path when the RPM package is being relocated during package install time.

If you're ok with the changes, can I get your help please to cut 1.0.5-RC2 containing this PR?

@muuki88
Copy link
Contributor

muuki88 commented Dec 4, 2015

LGTM. Could you have a look at #698 for me in return :)

@muuki88 muuki88 added the rpm label Dec 4, 2015
@fsat
Copy link
Collaborator Author

fsat commented Dec 6, 2015

@muuki88 - thanks for looking at this, and sorry for not getting to #698 sooner.

@muuki88
Copy link
Contributor

muuki88 commented Dec 6, 2015

@fsat no problem, really appreciate your help :)

muuki88 added a commit that referenced this pull request Dec 6, 2015
Ensure systemd works with RPM relocatable packages
@muuki88 muuki88 merged commit 45bc15f into sbt:master Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants