Travis: build on OS X (take 2) #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running more tests on OS X
Closed
| @@ -1,13 +1,19 @@ | |||
| language: scala | |||
| language: java | |||
There was a problem hiding this comment.
why is this change necessary? Because of this change we need to include a sbt launcher script, right?
There was a problem hiding this comment.
The sbt launcher script is unavailable on OS X anyway.
There was a problem hiding this comment.
(The other option would be to not include it in the repository but fetch it in before_install.)
muuki88
added a commit
that referenced
this pull request
Dec 13, 2015
Travis: build on OS X (take 2)
|
Having a dedicated launcher script is worth it, when we have OS X builds now. Thanks a lot for your effort :) |
|
@larsrh Psst, wise man use force push, young padawan 😎 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #714.