Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ant dependency for jdkpackager builds. Follow up to #719 #720

Merged
merged 2 commits into from
Jan 3, 2016

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Jan 1, 2016

Changing jdeb to a provided dependency removed the ant dependency from the runtime classpath, which is needed for the jdkpackager plugin.

Adding travis tests and dependency.

@muuki88
Copy link
Contributor Author

muuki88 commented Jan 1, 2016

@metasim you have any idea why this test breaks on travis ?

test-package-image/target/jdkpackager/build.xml:25: fx:info doesn't support the nested "association" element.

On my machine (Ubuntu 15.10, java version "1.8.0_66") things work.

@metasim
Copy link
Member

metasim commented Jan 2, 2016

@muuki88 I need to check the logs more, but my guess is that the travis config had JDK version less than 1.8.0_40, which is when the file association capability was added. Any idea if travis allows for finer grained Java version specifications?

@metasim
Copy link
Member

metasim commented Jan 2, 2016

Indeed, the failed build uses an older version of Java 1.8.0 (why the hell Oracle couldn't bump the minor revision number instead of this build number crap is beyond me).

java version "1.8.0_31"

@muuki88
Copy link
Contributor Author

muuki88 commented Jan 3, 2016

I'm afraid travis has no other way to specify the minor/patch versions in oracle-jdk. For now I ignore this test and add it when travis has upgraded their java version.

Thanks for looking into :)

@muuki88
Copy link
Contributor Author

muuki88 commented Jan 3, 2016

There is an issue (over a year old) which states that travis will upgrade soon (note in november) #3259

muuki88 added a commit that referenced this pull request Jan 3, 2016
Adding ant dependency for jdkpackager builds. Follow up to #719
@muuki88 muuki88 merged commit 409497a into master Jan 3, 2016
@muuki88 muuki88 deleted the wip/jdkpackager-dependencies branch January 3, 2016 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants