Add ability to expose UDP ports #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeQuissimus
commented
Sep 19, 2016
| @@ -207,8 +208,8 @@ object DockerPlugin extends AutoPlugin { | |||
| * @param exposedPorts | |||
| * @return if ports are exposed the EXPOSE command | |||
| */ | |||
| private final def makeExposePorts(exposedPorts: Seq[Int]): Option[CmdLike] = { | |||
| if (exposedPorts.isEmpty) None else Some(Cmd("EXPOSE", exposedPorts mkString " ")) | |||
| private final def makeExposePorts(exposedPorts: Seq[Int], exposedUdpPorts: Seq[Int]): Option[CmdLike] = { | |||
There was a problem hiding this comment.
Do we care? I think most of the methods in this class could have a more limited scope.
There was a problem hiding this comment.
Nope. I always forget to configure this :/
muuki88
approved these changes
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dockerExposedUdpPortssimilar to the existingdockerExposedPorts.Note that this depends on #880 for the tests to pass.
Fixed #843