Fixed: user defined scripts in debian overridden by generated files #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (script exists) Seq(file(script getAbsolutePath) -> scriptName) else Seq.empty | ||
| // check if user defined script exists | ||
| case (_, dir) if (dir / scriptName).exists => | ||
| Seq(file(dir / scriptName getAbsolutePath) -> scriptName) |
There was a problem hiding this comment.
post-fix notation is generally a bad idea. e.g. it's hard to tell what you're calling getAbsolutePath on here. I prefer to fully paranthesis, plus in scala 2.11 this may actually just become a compile error.
|
Besides on minor style comment, this looks great! I agree that things on disk should override the generated ones. |
|
LGTM |
jsuereth
added a commit
that referenced
this pull request
Dec 4, 2013
Fixed: user defined scripts in debian overridden by generated files
|
Thanks again! Regards, Alexey
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.