Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-08-failOnClassesExcludedFromJarStar fail #41

Open
xuwei-k opened this issue Aug 11, 2017 · 5 comments
Open

test-08-failOnClassesExcludedFromJarStar fail #41

xuwei-k opened this issue Aug 11, 2017 · 5 comments
Assignees

Comments

@xuwei-k
Copy link
Member

xuwei-k commented Aug 11, 2017

[info] [info] Validating all packages are set private or exported for OSGi explicitly...
[info] [success] Total time: 1 s, completed Aug 12, 2017 1:49:18 AM
[error] x sbt-osgi / test-08-failOnClassesExcludedFromJarStar
[error]    {line 1}  Command succeeded but failure was expected
[trace] Stack trace suppressed: run last *:scripted for the full output.
[error] (*:scripted) Failed tests:
[error] 	sbt-osgi / test-08-failOnClassesExcludedFromJarStar
[error] Total time: 27 s, completed Aug 12, 2017 1:49:19 AM
@ktoso
Copy link
Member

ktoso commented Aug 12, 2017

I don't maintain this plugin ;) I just fixed a bug once

@xuwei-k
Copy link
Member Author

xuwei-k commented Aug 12, 2017

You have added this test in 5b93fbe.

Should we remove this test? or fix as follows?

- -> verify-bundle
+ > verify-bundle

http://www.scala-sbt.org/0.13/docs/Testing-sbt-plugins.html

# starts a one-line comment
> name sends a task to sbt (and tests if it succeeds)
$ name arg* performs a file command (and tests if it succeeds)
-> name sends a task to sbt, but expects it to fail
-$ name arg* performs a file command, but expects it to fail

@ktoso
Copy link
Member

ktoso commented Aug 12, 2017

I see, I'll get back to this once at a computer then. Thanks for reporting

@ktoso
Copy link
Member

ktoso commented Aug 14, 2017

I'm working on this today

@ktoso
Copy link
Member

ktoso commented Aug 15, 2017

It was an actual bug. Submitting PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants