-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a custom release of sbt-osgi 0.9.4 + Invalid CEN extra data field patch #93
Comments
I'm ok with whatever approach that unblocks you folks, but I guess a better approach would be to bisect to identify the regression and revert it. |
I would normally do this but because of the pressure that Pekko has to unbreak the branches and/or whether reverting that commit won't cause more problems (I assume it was done for a reason). In any case I will go ahead and make the branch |
My hope was, that PR #79 might fix it. @mdedetrich could you please test this PR? |
In case, #75 is related, an potential workaround is described here: akka/akka#31437 (comment) |
@lefou Sure, I just initiated a release of |
Closing as completed, can confirm that |
@lefou I can confirm that this didn't fix the underlying issue, at least with Pekko |
Too bad. Thanks for checking. |
At pekko we are using sbt-osgi and we have encountered a regression that occurred between 0.9.4 and 0.9.5 whereby there are duplicate classes/jars, see apache/pekko#745 (comment) for more info.
Ordinarily this regression wouldn't have been an issue since we could just stick to 0.9.4 but because of #81 0.9.4. no longer works. In the interests of unblocking pekko (currently both the
main
and1.0.x
branches are broken due to this) would it be possible to create patched release of 0.9.4. containing #81 ?In my mind I would create a new branch based off of 0.9.4, cherry picking the relevant build/org updates along with the patch and then we can cut a release by pushing a git tag (I was thinking
0.9.4-INVALID-CEN-JAR-PATCH
?)@eed3si9n @xuwei-k @romainreuillon thoughts?
The text was updated successfully, but these errors were encountered: