Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer versions of GNU PG #131

Merged
merged 3 commits into from May 27, 2018
Merged

Conversation

rhpvorderman
Copy link
Contributor

@rhpvorderman rhpvorderman commented May 23, 2018

Changes where made for gnupg >= 2.1
This hopes to fix #72.
A SettingKey gpgAncient was added that you can set to true if you want to old behaviour. (Disclaimer: sorry for the slightly opinionated name. I could not think of something else. If someone knows a better one I am happy to change it)

Edit: I also added some code to make debugging the gpg command easier in the future.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I am going to keep this open a bit to solicit more reviews.

@eed3si9n
Copy link
Member

@jvican @djspiewak Either of you want to help review this?

Copy link

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. I'd still like useGpg to default to true, but that's obviously a major compatibility shift. This at least gives people the ability to move forward in the interim.

@eed3si9n eed3si9n merged commit f2fcef9 into sbt:master May 27, 2018
@wookietreiber
Copy link

Thank you for the commitment in fixing this issue. Please release this in a new version of sbt-pgp.

@steinybot
Copy link

So does this log the passphrase on error now?

fleipold added a commit to programmiersportgruppe/sbt-tabular-test-reporter that referenced this pull request Dec 10, 2018
fleipold added a commit to programmiersportgruppe/sbt-tabular-test-reporter that referenced this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPG 2.1+ doesn't use secret keyring anymore
5 participants