protobufExcludeFilters #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** When compiling complex protobuf schema, you often run into a situation where you need some external schema during the compilation, but you don't necessarily want to include the resulting Java output as your own output because there's already a precompiled or well-known bytecode version of the class. A good example of this is classes under com/google/protobuf, but there are others as well. In theory sbt#29 has added excludeFilter support, but in practice sbt's file filter doesn't work for directory name matching. **Solution** This reimplements the protobuf file filtering using the new Glob, which can match directory names. As a demonstration, `protobufExcludeFilters` is initialized to glob `Glob(d.toPath()) / "google" / "protobuf" / "*.proto"`. This will filter out protobuf sources which are precompiled in "com.google.protobuf" % "protobuf-java".
This was referenced Mar 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
Problem
When compiling complex protobuf schema, you often
run into a situation where you need some external
schema during the compilation, but you don't
necessarily want to include the resulting Java
output as your own output because there's already
a precompiled or well-known bytecode version of
the class.
A good example of this is classes under com/google/protobuf, but there are others as well.
In theory #29 has added excludeFilter support,
but in practice sbt's file filter doesn't work
for directory name matching.
Solution
This reimplements the protobuf file filtering
using the new Glob, which can match directory names.
As a demonstration,
protobufExcludeFiltersisinitialized to glob
Glob(d.toPath()) / "google" / "protobuf" / "*.proto". This will filter out protobuf sources whichare precompiled in "com.google.protobuf" % "protobuf-java".