Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There were two issues with the server tests on windows 1) Sometimes client connections fail on the first attempt but will succeed with retries 2) It is possible for named pipes to leak which causes subsequent tests to be unable to run 3) ClientTest did not handle lines with carriage returns correctly Issue #1 is fixed with retries. Issue #2 is fixed by using a unique temp directory for each test run. Issue #3 was fixed by simplifying the output stream cache to only cache the bytes returned and then letting scala do the line splitting for us in linesIterator. After these changes, all of the server tests work on appveyor.
- Loading branch information
Showing
3 changed files
with
23 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters