Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid binary version conflict warnings with a custom configuration #1466

Closed
eed3si9n opened this issue Jul 25, 2014 · 0 comments
Closed

Invalid binary version conflict warnings with a custom configuration #1466

eed3si9n opened this issue Jul 25, 2014 · 0 comments
Assignees
Milestone

Comments

@eed3si9n
Copy link
Member

steps

$ cat build.sbt
lazy val TheDude = config("dude")

lazy val rootProj = (project in file(".")).
  configs(TheDude).
  settings(inConfig(TheDude)(Defaults.compileSettings): _*).
  settings(
    name := "hello",
    version := "0.1.0-SNAPSHOT",
    scalaVersion := "2.11.1",
    libraryDependencies += "org.scala-lang" % "scala-library" % "2.10.4" % TheDude
  )
$ sbt
hello> clean
hello> dude:compile

problem

hello> dude:compile
[info] Updating {file:/Users/eugene/work/quick-test/minimal-scala/}rootProj...
[warn] Binary version (2.10) for dependency org.scala-lang#scala-library;2.10.4
[warn]  in hello#hello_2.11;0.1.0-SNAPSHOT differs from Scala binary version in project (2.11).
[info] Resolving jline#jline;2.11 ...
[info] Done updating.

TheDude configuration is independent from Compile, so the fact the warning is incorrect there.

expectation

Should we allow scalaVersion to be set on custom configurations? If so does that change the behavior of %%? Probably not because you could have more than one config like default->@;runtime,test->runtime. So that means, each configuration should use scala-library's version to be the basis on checking for binary version conflicts.

@eed3si9n eed3si9n added this to the 0.13.6 milestone Jul 25, 2014
@jsuereth jsuereth modified the milestones: 0.13.6, 0.13.7 Aug 1, 2014
@eed3si9n eed3si9n modified the milestone: 0.13.7 Nov 4, 2014
@eed3si9n eed3si9n added this to the 0.13.14 milestone Nov 11, 2016
@eed3si9n eed3si9n self-assigned this Nov 11, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this issue Nov 11, 2016
Fixes sbt#1466 Ref sbt#2786

Even after fixing the mediator issue, we still have spurious binary
version conflict warning that does not account for sandbox
configurations.

This change follows the scalaVersionConfigs work.
eed3si9n added a commit to eed3si9n/sbt that referenced this issue Nov 11, 2016
Fixes sbt#1466 Ref sbt#2786

Even after fixing the mediator issue, we still have spurious binary
version conflict warning that does not account for sandbox
configurations.

This change follows the scalaVersionConfigs work.
eed3si9n added a commit to eed3si9n/sbt that referenced this issue Nov 11, 2016
Fixes sbt#1466 Ref sbt#2786

Even after fixing the mediator issue, we still have spurious binary
version conflict warning that does not account for sandbox
configurations.

This change follows the scalaVersionConfigs work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants