Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptedPlugin: Add support for paginated tests (scripted foo/*1of3) #3013

Closed
smarter opened this issue Mar 14, 2017 · 2 comments
Closed

ScriptedPlugin: Add support for paginated tests (scripted foo/*1of3) #3013

smarter opened this issue Mar 14, 2017 · 2 comments
Assignees

Comments

@smarter
Copy link
Contributor

smarter commented Mar 14, 2017

This is another issue like #2601 where ScriptedPlugin is less powerful than the internal Scripted used by sbt, which supports paginated tests which are very useful when running on a CI: 5d5d7a6

@eed3si9n
Copy link
Member

sure. Would you like to send in a PR?

@smarter
Copy link
Contributor Author

smarter commented Mar 14, 2017

On my way!

smarter added a commit to smarter/sbt that referenced this issue Mar 14, 2017
This was already supported in the internal Scripted used by sbt but not
in the ScriptedPlugin. This is fixed by just copy-pasting the modified
parser. We will have to wait for sbt itself to be built using an sbt
with the upgraded ScriptedPlugin to be able to avoid the code duplication.
eed3si9n added a commit that referenced this issue Mar 15, 2017
Fix #3013: ScriptedPlugin: Add support for paginated tests
eed3si9n pushed a commit to eed3si9n/sbt that referenced this issue Apr 4, 2017
This was already supported in the internal Scripted used by sbt but not
in the ScriptedPlugin. This is fixed by just copy-pasting the modified
parser. We will have to wait for sbt itself to be built using an sbt
with the upgraded ScriptedPlugin to be able to avoid the code duplication.
@eed3si9n eed3si9n self-assigned this Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants