Proxy repo config #472
Closed
Proxy repo config #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added key which pulls the repositories used by the launcher, if the API allows. * Added which configures whether or not should just use . * Added parsing to launcher so java property is used by default for override setting.
* Configuration parsing now looks for a ivy.resolver-config property for alternative resolver config. * ivy.resolver-config defaults to ~/.sbt/repositories * If the resolve config file exists, its [resolvers] section is used instead of sbt-launch.jar's * Attempted to re-use as much code as possible and add as little as needed.
|
Looks good. There are a few minor suggestions to take care of and it will be ready to merge. |
* Puppies may rest easy from the removal of Option.get calls. * better names for config values * Added a helper method to avoid any possible code duplication, besides repeated def, val, match and for keywords. Looking for ways to remove this duplciation ASAP. * Moved from pattern match to ._1, my most hated member.
|
Alright, fixes in place. Feel free to take a second gander. Note: Commit messages reflect my unusually mirthful state and hopefully are not offensive. |
|
Merged in harrah@76d2409 |
|
Just a note: Issue #414 might want to get closed once this is validated? |
Closed
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch it's now possible to force builds to use only boot resolvers with
the following:
-Dsbt.override.build.repos=trueAlso, you can configure a
/.sbt/repositoriesfile such that only proxy repositories show up. Here's what mine looks like:Closes #414 (For me at least. Some testing from more complicated builds would be ideal.)