New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove work-arounds for Scala 2.11 problematic dependencies #1114
Conversation
The ff0fd6e introduced some exclusions that were necessary for getting sbt to resolve dependencies properly against Scala 2.11.0-M7. Scala 2.11.0-M8 fixed its dependency structure so we can get rid of those exclusions now.
Review by @retronym |
LGTM - was this tested with the dbuild scripts? |
I tested it by building the whole sbt myself. See #1113. I'm happy to run a dbuild job as well. Can you give me a pointer which one specifically I should run? |
That build doesn't compile all of SBT:
Can we crank up the coverage? |
LGTM. I used this patch locally earlier today. |
Ah, right. We used to not build all of it because of 2.11 incompatibilities with macros. We can crank up the coverage once we figure out why it's not working inside the pr-validation automation. |
Remove work-arounds for Scala 2.11 problematic dependencies
Just because it builds locally doesn't mean it won't break all the crazy integration scripts we have between projects. particularly anything that alters dependencies may cause issues in the dbuild script. I'd prefer if we don't merge these types of changes until we can validate that the IDE integration still works, thanks. |
Sorry. That stuff is only a problem if you're using M7 or earlier. Incidentally, I'm working on dbuild at the moment, resurrecting the Community 2.11 build. |
Cool. I just want to make sure it doesn't break our existing dbuild scripts though. Our version.properties is still on M7 for our nightlies, and my PR is still hanging in the air to update that. |
Remove work-arounds for Scala 2.11 problematic dependencies
The ff0fd6e introduced some exclusions
that were necessary for getting sbt to resolve dependencies properly
against Scala 2.11.0-M7.
Scala 2.11.0-M8 fixed its dependency structure so we can get rid of those
exclusions now.