Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove work-arounds for Scala 2.11 problematic dependencies #1114

Merged
merged 1 commit into from Feb 12, 2014

Conversation

gkossakowski
Copy link
Contributor

The ff0fd6e introduced some exclusions
that were necessary for getting sbt to resolve dependencies properly
against Scala 2.11.0-M7.

Scala 2.11.0-M8 fixed its dependency structure so we can get rid of those
exclusions now.

The ff0fd6e introduced some exclusions
that were necessary for getting sbt to resolve dependencies properly
against Scala 2.11.0-M7.

Scala 2.11.0-M8 fixed its dependency structure so we can get rid of those
exclusions now.
@gkossakowski
Copy link
Contributor Author

Review by @retronym

@jsuereth
Copy link
Member

LGTM - was this tested with the dbuild scripts?

@gkossakowski
Copy link
Contributor Author

I tested it by building the whole sbt myself. See #1113.

I'm happy to run a dbuild job as well. Can you give me a pointer which one specifically I should run?

@jsuereth
Copy link
Member

@retronym
Copy link
Member

That build doesn't compile all of SBT:

          projects: ["compiler-interface",
                     "classpath","logging","io","control","classfile",
                     "process","relation","interface","persist","api",
                     "compiler-integration","incremental-compiler","compile","launcher-interface"

Can we crank up the coverage?

@retronym
Copy link
Member

LGTM. I used this patch locally earlier today.

@jsuereth
Copy link
Member

Ah, right. We used to not build all of it because of 2.11 incompatibilities with macros. We can crank up the coverage once we figure out why it's not working inside the pr-validation automation.

@gkossakowski
Copy link
Contributor Author

@jsuereth: as noted in #1113 I've built entire sbt on top of Scala 2.11.0-M8 locally so I think it should work now.

retronym added a commit that referenced this pull request Feb 12, 2014
Remove work-arounds for Scala 2.11 problematic dependencies
@retronym retronym merged commit 9428bb3 into sbt:0.13 Feb 12, 2014
@jsuereth
Copy link
Member

Just because it builds locally doesn't mean it won't break all the crazy integration scripts we have between projects. particularly anything that alters dependencies may cause issues in the dbuild script. I'd prefer if we don't merge these types of changes until we can validate that the IDE integration still works, thanks.

@retronym
Copy link
Member

Sorry. That stuff is only a problem if you're using M7 or earlier.

Incidentally, I'm working on dbuild at the moment, resurrecting the Community 2.11 build.

@jsuereth
Copy link
Member

Cool. I just want to make sure it doesn't break our existing dbuild scripts though. Our version.properties is still on M7 for our nightlies, and my PR is still hanging in the air to update that.

jvican pushed a commit to scalacenter/sbt that referenced this pull request May 23, 2017
Remove work-arounds for Scala 2.11 problematic dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants