Accumulate Test Count #1364
Merged
Accumulate Test Count #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith latest one. This solves the test result count problem when a Suite is executed more than 1 time due to being returned as nested suites (sub-task).
|
LGTM. @jsuereth? |
|
LGTM - Test failure looks to be the 'empty key string' failure that Dan fixed in another PR. Thanks again @cheeseng for the fixes! |
|
Thanks Eugene and Josh for pulling this in! On Fri, May 23, 2014 at 9:37 PM, Josh Suereth notifications@github.comwrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to combine SuiteResult with same name, instead of replacing with latest one. This solves the test result count problem when a Suite is executed more than 1 time due to being returned as nested suites (sub-task).
This solves incorrect test count problem when a suite in ScalaTest is executed more than one time as nested suites, current code simply replace the old count with the new count, this changes will add them up instead.
The following is an issue reported in ScalaTest that drive this request:
scalatest/scalatest#167