Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resolve exception #1447

Merged
merged 2 commits into from Jul 14, 2014
Merged

Improve resolve exception #1447

merged 2 commits into from Jul 14, 2014

Conversation

eed3si9n
Copy link
Member

fixes #1422, #381

steps

lazy val d = project.
  settings(
    libraryDependencies += "org.apache.cayenne.plugins" % "maven-cayenne-plugin" % "3.0.2"
  )

problem

You have no idea which transitive deps path failed.

what this changes

[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: foundrylogic.vpp#vpp;2.2.1: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn] 
[warn]  Note: Unresolved dependencies path:
[warn]      foundrylogic.vpp:vpp:2.2.1
[warn]        +- org.apache.cayenne:cayenne-tools:3.0.2
[warn]        +- org.apache.cayenne.plugins:maven-cayenne-plugin:3.0.2
[warn]        +- d:d_2.10:0.1-SNAPSHOT

jsuereth
jsuereth reviewed Jul 14, 2014
View reviewed changes
ivy/src/main/scala/sbt/IvyActions.scala
val failed = resolveReport.getUnresolvedDependencies.map(node => IvyRetrieve.toModuleID(node.getId))
Some(new ResolveException(messages, failed))
val failedPaths = Map(resolveReport.getUnresolvedDependencies map { node =>
val m = IvyRetrieve.toModuleID(node.getId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the part you worried was slow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you picked it up when you saw findPath, but the imple of findPath is what I'm worried.

@jsuereth
Copy link
Member

LGTM

jsuereth added a commit that referenced this pull request Jul 14, 2014
@jsuereth
Merge pull request #1447 from sbt/wip/improve-resolve-exception
4f3da04 
Improve resolve exception
@jsuereth jsuereth merged commit 4f3da04 into 0.13 Jul 14, 2014
@jsuereth jsuereth deleted the wip/improve-resolve-exception branch July 14, 2014 14:05
This was referenced Aug 15, 2019
Closed
Merged
@eed3si9n eed3si9n mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eed3si9n @jsuereth