Add Ivy branch support to ModuleID [1.0.x] + fix CacheIvy
#2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
eed3si9n
added a commit
that referenced
this pull request
Mar 7, 2016
Add Ivy `branch` support to ModuleID [1.0.x] + fix CacheIvy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the counterpart to sbt/librarymanagement#26 that I mentioned.
Together with that PR, these are a forward port (to
1.0.x) of the changes initially proposed in #1994.This particular PR:
branchNameinFormat[ModuleID]CacheIvychange introduced by Handle source, docs artifacts correctly for Ivy [1.0.x] #2475 at this line (sorry!)CacheIvyTestthat ensures a cached-then-retrievedModuleIDremains equal to the original (save for CrossVersion, which is not being cached perfectly)