Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sbt 1.0] Improve show when key returns a Seq #2752

Merged
merged 1 commit into from Sep 23, 2016

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Sep 23, 2016

This changes the output to:

> show externalDependencyClasspath
[info] Updating {file:/xxx/hello/}root...
[info] Resolving jline#jline;2.12.1 ...
[info] Done updating.
[info] * Attributed(/Users/xxx/.sbt/boot/scala-2.11.8/lib/scala-library.jar)
[info] * Attributed(/Users/xxx/.ivy2/cache/commons-io/commons-io/jars/commons-io-
2.4.jar)

/review @dwijnand, @Duhemm

This changes the output to:

```
> show externalDependencyClasspath
[info] Updating {file:/xxx/hello/}root...
[info] Resolving jline#jline;2.12.1 ...
[info] Done updating.
[info] *
Attributed(/Users/xxx/.sbt/boot/scala-2.11.8/lib/scala-library.jar)
[info] *
Attributed(/Users/xxx/.ivy2/cache/commons-io/commons-io/jars/commons-io-
2.4.jar)
```
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingly beautiful and amazingly simple.

@dwijnand
Copy link
Member

Can we backport this too?

@eed3si9n
Copy link
Member Author

Can we backport this too?

I'm not sure if we count this as semantic change. If we do we might have to guard it with an opt-out flag.

@dwijnand
Copy link
Member

I'm happy with an opt-out.

@dwijnand dwijnand merged commit bd1b3cf into sbt:1.0.x Sep 23, 2016
@eed3si9n eed3si9n deleted the wip/showseq branch September 23, 2016 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants