Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-triggered scripted plugin: SbtPlugin #3875

Merged
merged 6 commits into from Jan 24, 2018
Merged

non-triggered scripted plugin: SbtPlugin #3875

merged 6 commits into from Jan 24, 2018

Commits on Jan 22, 2018

  1. Make ScriptedPlugin not a triggered plugin 

    Fixes sbt#3514
    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    655c2ac View commit details
    Browse the repository at this point in the history

  2. Add SbtPlugin 

    Fixes sbt#3538

This brings in `sbt.ScriptedPlugin` as `sbt.plugins.ScriptedPlugin` into sbt mothership.
In addition, `sbt.plugins.SbtPlugin` is added that enables the scripted plugin and `sbtPlugin := true`.

This allows plugin authors to bring in scripted plugin by writing:

```scala
lazy val root = (project in file("."))
  .enablePlugins(SbtPlugin)
```
    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    08eaba9 View commit details
    Browse the repository at this point in the history

  3. move some scripted defaults settings to global 

    Fixes sbt#3656
    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    b05802f View commit details
    Browse the repository at this point in the history

  4. Work around package name confusion 

    This works around the name conflict between sbt.test package and sbt.Keys.test.

1. sbt.test package is renamed to sbt.scriptedtest. This allows 1.0 plugins and builds to use `test` to mean `Keys.test`.
2. To keep binary compatibility for sbt 0.13 scripted, I am adding `sbt.test.ScriptedRunner` and `sbt.test.ScriptedTests` in `scripted-plugin` artifact.
3. Another affected user is Giter8 plugin that uses ScriptedPlugin. Since the intereactions are limited to `sbt.ScriptedPlugin.*`, we should be fine here. - https://github.com/foundweekends/giter8/blob/v0.11.0-M2/plugin/src/main/scala-sbt-1.0/giter8/SBTCompat.scala
    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    c20029c View commit details
    Browse the repository at this point in the history

  5. notes

    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    0d83b2f View commit details
    Browse the repository at this point in the history

  6. Migrate to the new way of enabling scripted

    @eed3si9n
    eed3si9n committed Jan 22, 2018
    Copy the full SHA
    58ee24b View commit details
    Browse the repository at this point in the history