Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #4370 #4378

Merged
merged 1 commit into from Sep 25, 2018
Merged

Fix: #4370 #4378

merged 1 commit into from Sep 25, 2018

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Sep 24, 2018 •
edited

This is a trivial fix for #4370

I have still two observations:

  1. A server can crash at any point in time, I think is responsibility of the client to watch if the server is alive and behave accordingly
  2. The testing infrastructure for the LSP Server is extremely sensitive, I hacked it around to keep things working, but it will be worth to understand how we can do better.

@eed3si9n eed3si9n added the ready label Sep 24, 2018
@eed3si9n
Copy link
Member

Nice. Thanks @andreaTP!

@andreaTP
Copy link
Contributor Author

finalized and already squashed, ready for review.

@eed3si9n eed3si9n merged commit 125087a into sbt:develop Sep 25, 2018
@eed3si9n eed3si9n removed the ready label Sep 25, 2018
@eed3si9n eed3si9n added this to the 1.3.0 milestone Apr 26, 2019
@lukoyanov lukoyanov mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreaTP @eed3si9n