Fix for JUnitXmlTestsListener that is removing part of test name when it contains dot

[margussipria]

Attempt to fix #5114 (and #2949)

[lightbend-cla-validator]

Hi @margussipria,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

[eed3si9n]

@margussipria Thanks for the contribution.
It seems like there are some scripted tests here that might be of your interest - https://github.com/sbt/sbt/blob/develop/sbt/src/sbt-test/tests/junit-xml-report/build.sbt

[eed3si9n]

[error] 1 files must be formatted
[error] (testingProj / Compile / scalafmtCheck) 1 files must be formatted

[margussipria]

I formatted the code, also Fixed MyNestedSuites test where MyInnerSuite isn't part of name.

Also added new coverage and new test checking names of testcases covering name with dot in it.

[eed3si9n]

@margussipria Thanks for the update. Also have you signed the CLA?
http://www.lightbend.com/contribute/cla

[margussipria]

I did sign it now, but that check didn't change?

[margussipria]

Added some function return types so CLA test would be run again, those would be needed in distant future when migrating to and past Scala 2.13 so not totally worthless commit.

[eed3si9n]

LGTM

[margussipria]

is it possible to get this also to 1.3.x branch?

[eed3si9n]

Sure.

[HeartSaVioR]

Do you have any update on this, given it was merged in Oct last year? Are there any releases containing this?

[margussipria]

@eed3si9n about backporting this, who should do it? (expected that not me, "but who then")

[eed3si9n]

Normally I do the backports. Looks like this slipped through the cracks.

[HeartSaVioR]

Hopefully sbt has been releasing bugfix versions monthly - unless there's a long pause, wouldn't be a big deal.