Allow using a projectref across scala versions with cross building #5511
Conversation
raboof
force-pushed
the
cross-version-projectref-develop
branch
from
ca1ccdd
to
fa9557d
Compare
| case Seq() => Nil // should be unreachable | ||
| case multi if fullArgs.isEmpty => | ||
| Seq(s"$SwitchCommand $verbose $v! all ${multi.mkString(" ")}") | ||
| case multi => Seq(s"$SwitchCommand $verbose $v!") ++ multi | ||
| case multi => Seq(s"$SwitchCommand $verbose $v") ++ multi |
There was a problem hiding this comment.
Hmm, in #5494 I didn't really know what I was doing and I aggressively removed the use of !. Is it necessary to remove the use of ! in all three code occurrences to fix the issue?
After I sent #5494 I started thinking I might introduce other regressions.
PS: I noticed you didn't edit line 201 which makes me assume you indeed change the minimum occurrences required 😂
There was a problem hiding this comment.
The reproducer doesn't need all 3 changes, but it would be quite inconsistent to not change all of these occurrences, as they seems quite similar. I'm definitely not familiar enough with this code to predict all the possible effects of this change, but at least the test suite doesn't appear to signal any regressions.
| // Force scala version | ||
| Seq(s"$SwitchCommand $verbose $version!", aggCommand) | ||
| // Set scala version | ||
| Seq(s"$SwitchCommand $verbose $version", aggCommand) |
There was a problem hiding this comment.
I think this ! is necessary for sbt 0.13 emulation - #5497 (comment)
|
Closing this in favor of #5512 |
Reproduces #5497 and contains the fix by @ignasi35 from #5494 - I'm not seeing
actions/cross-test-only fail here