Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console with -Dsbt.ci=true #6067

Merged
merged 1 commit into from Nov 6, 2020
Merged

Fix console with -Dsbt.ci=true #6067

merged 1 commit into from Nov 6, 2020

Commits on Nov 5, 2020

  1. Fix console with -Dsbt.ci=true

    If a user runs sbt -Dsbt.ci=true with the latest code, sbt immediately
    exits. This was because we were passing the SimpleTerminal into jline3
    and jline 3 would end up exiting immediately. Instead we can still make
    a console terminal if there is a console available. An alternative
    approach would have been to use a dumb terminal with -Dsbt.ci=true, but
    the dumb terminal experience is not great (tab completions don't work
    for example), so I thought this was a better fix.
    eatkins committed Nov 5, 2020
    Copy the full SHA
    c1fcf5c View commit details
    Browse the repository at this point in the history