Fix #6092 - sbt 1.4.0~1.4.3 - all the files in the packaged jar files created at epoch millisecond 0 (1970-01-01 00:00:00) #6093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created at epoch millisecond 0 (1970-01-01 00:00:00)
eed3si9n
reviewed
Nov 16, 2020
| sys.env.get("SOURCE_DATE_EPOCH").map(_.toLong * 1000).orElse(Some(0L)) | ||
| sys.env.get("SOURCE_DATE_EPOCH").map(_.toLong * 1000) |
There was a problem hiding this comment.
Zeroing out the JAR was done so intentionally in #5344 to make the packaging more reproducible.
There was a problem hiding this comment.
Ah... Alright I should need to read to understand it but I have a very quick question.
Should it be 0L or any fixed epoch milliseconds? If it's latter one, can it be Some(System.currentTimeMillis())?
There was a problem hiding this comment.
OK I got it. I will use sbt 1.3.13 or use SOURCE_DATE_EPOCH env var if the timestamp of the class file is important. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6092 - sbt 1.4.0~1.4.3 - all the files in the packaged jar files created at epoch millisecond 0 (1970-01-01 00:00:00)
Before
After
