Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala3doc #6234

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Add support for Scala3doc #6234

merged 5 commits into from
Jan 4, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Dec 29, 2020

Part of #6080

@adpi2 adpi2 force-pushed the scala3doc branch 10 times, most recently from 8542d57 to a815d1e Compare December 31, 2020 10:23
@adpi2
Copy link
Member Author

adpi2 commented Dec 31, 2020

This PR depends on:

The scala3doc dependency is added only if externalResolvers contains the JCenter repository.

It is added to a separate ivy configuration, called ScalaDocTool, so that we have two distinct lists of jars: one list for scala3-compiler and another one for scala3doc. Then we can easily create the compiler class loader and the scala3doc class loader whose parent is the compiler class loader.

To make doc works with Scala 3, the user must add the JCenter repository manually:

resolvers += Resolver.JCenterRepostiory

Once scala3doc has been migrated away from dokka, JCenter won't be needed anymore and the scala3doc dependency will be added by default.

In order to merge this PR, we need to merge sbt/librarymanagement#359 and sbt/zinc#960 and to release them. Also I will remove the commit 5dfb304 (it forces the CI to run on my zinc and libmanagement branches)

@adpi2 adpi2 force-pushed the scala3doc branch 2 times, most recently from 53a0120 to 5dfb304 Compare December 31, 2020 12:13
@adpi2 adpi2 marked this pull request as ready for review December 31, 2020 12:47
@adpi2 adpi2 requested a review from eed3si9n December 31, 2020 12:47
@adpi2 adpi2 mentioned this pull request Dec 31, 2020
@eed3si9n
Copy link
Member

eed3si9n commented Jan 3, 2021

Zinc 1.5.0-M2 and lm 1.5.0-M3 are available.

@adpi2
Copy link
Member Author

adpi2 commented Jan 4, 2021

Thanks @eed3si9n
It's now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants