Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNU Emacs support for sbtn and sbt --client #6276

Merged
merged 3 commits into from Jan 21, 2021
Merged

GNU Emacs support for sbtn and sbt --client #6276

merged 3 commits into from Jan 21, 2021

Conversation

fommil
Copy link
Contributor

@fommil fommil commented Jan 21, 2021

fixes #6271

@hvesalai can you please take a look? Do you think this will be compatible with sbt-mode now that I'm enabling colours by default? If not, we can always disable the colours from sbt-mode with a system property.

@lightbend-cla-validator

Hi @fommil,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@hvesalai
Copy link
Contributor

Sbt-mode can handle (and does handle) colors. Not a problem.

image

@eed3si9n eed3si9n merged commit cc87ae2 into sbt:develop Jan 21, 2021
@fommil fommil deleted the emacs branch January 22, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbt server does not stay up when sbtn is called from emacs
4 participants