Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain classifiers for transitive dependencies when publishing to Ivy using Coursier #6456

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Retain classifiers for transitive dependencies when publishing to Ivy using Coursier #6456

merged 1 commit into from
Apr 19, 2021

Conversation

guilgaly
Copy link
Contributor

Fixes #5325

Notes:

  • I reproduced the issue (and tested the fix) on a private repo, but I can provide a public reproducer project if that's useful for someone else
  • the format of the <artifact ... /> XML element is copied from what I got when publishing with useCoursier := false, since that worked

@guilgaly guilgaly mentioned this pull request Apr 19, 2021
Closed
eed3si9n
eed3si9n approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guilgaly!

@eed3si9n
Copy link
Member

The test failure seems unrelated.

@eed3si9n eed3si9n merged commit 943677e into sbt:develop Apr 19, 2021
@eed3si9n eed3si9n added this to the 1.5.1 milestone Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

Transitive dependencies with classifier are not pulled
2 participants
@guilgaly @eed3si9n