Drop TrapExit #6665
Merged
Drop TrapExit #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/drop_trapexit
branch
2 times, most recently
from
79812ba
to
cd0d94e
Compare
Fixes sbt#6558 Problem ------- sbt uses SecurityManager feature of JDK to trap `sys.exit` call during `run`-like tasks, since we emulate `run` and `console` as function calls. JDK 17 deprecated SecurityManager and it's printing warnings. Solution -------- About 10 years go, `exit` was a convenient way of quitting both Scala REPL and sbt shell. Scala 2.11 broke this by removing the `Predef.exit`. We still need to worry about `run` potentially calling `sys.exit` but that can be handled using fork feature. In the long-run, it probably is better to be JDK 17 compatible.
eed3si9n
force-pushed
the
wip/drop_trapexit
branch
from
cd0d94e
to
0413727
Compare
|
Should we deprecate or remove |
I think that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6558
Problem
sbt uses SecurityManager feature of JDK to trap
sys.exitcall duringrun-like tasks, since we emulaterunandconsoleas function calls.JDK 17 deprecated SecurityManager and it's printing warnings.
Solution
About 10 years go,
exitwas a convenient way of quitting both ScalaREPL and sbt shell. Scala 2.11 broke this by removing the
Predef.exit.We still need to worry about
runpotentially callingsys.exitbut that can be handled using fork feature.
In the long-run, it probably is better to be JDK 17 compatible.