Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cycles while rendering dependency tree to json #6675

Merged
merged 1 commit into from Sep 30, 2021
Merged

Handle cycles while rendering dependency tree to json #6675

merged 1 commit into from Sep 30, 2021

Conversation

nimatrueway
Copy link
Contributor

@nimatrueway nimatrueway commented Sep 28, 2021

This PR handles cycles in TreeView.createJson (used in task dependencyBrowseTree) the same way it is handled in Graph.toAscii (used in task dependencyTree).

The effect is:
image

  • Top picture is dependency tree rendered into a json shown on a web page after this fix (task: dependencyBrowseTree)
  • Bottom picture is the dependency tree rendered to ascii on console (task: dependencyTree)

@lightbend-cla-validator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

1 similar comment
@lightbend-cla-validator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@nimatrueway
Copy link
Contributor Author

I did sign the CLA.

@nimatrueway nimatrueway changed the title Handle cycles while rendering json dependency tree to json Handle cycles while rendering dependency tree to json Sep 28, 2021
@eed3si9n
Copy link
Member

At least one pull request committer is not linked to a user.

@nimatrueway Thanks for the contribution. I think the robot is complaining that the email used to make the commit is not associated with your GitHub account. If you used work or personal email make sure those are added to your GitHub account (you can hide them as private), or commit again under the correct --author.

git commit --amend --author="Foo <foo@example.com>" --no-edit

@nimatrueway
Copy link
Contributor Author

Oops, so sorry! Thanks @eed3si9n for the nice tip. 🙏🏻

@nimatrueway
Copy link
Contributor Author

Added copyright header to "TreeViewTest" to make checks pass.

@eed3si9n eed3si9n merged commit 35003a0 into sbt:develop Sep 30, 2021
@nimatrueway nimatrueway deleted the fix-cycle-in-browse-tree branch September 30, 2021 04:14
@eed3si9n eed3si9n added this to the 1.6.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants