Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix SbtRefactorings and run SessionSettingsSpec #7494

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Feb 13, 2024

No description provided.

The compiler cannot infer F[_] on a concrete Tuple.Map[T, F[_]] because it reduces it to a (F[A], F[B], ...)
@adpi2 adpi2 changed the title [sbt2] Fix SbtRefactorings and run SessionSettingsSpec [sbt2] Fix SbtRefactorings and run SessionSettingsSpec Feb 13, 2024
@adpi2
Copy link
Member Author

adpi2 commented Feb 13, 2024

@eed3si9n It seems that SbtRefactorings can only rewrite simple settings such as a := { // body }. I wonder if it is so much useful and if we should keep it or discard it.

@adpi2 adpi2 mentioned this pull request Feb 13, 2024
31 tasks
@adpi2 adpi2 changed the title [sbt2] Fix SbtRefactorings and run SessionSettingsSpec [2.x] Fix SbtRefactorings and run SessionSettingsSpec Feb 13, 2024
@eed3si9n
Copy link
Member

This is used for session save?

@adpi2
Copy link
Member Author

adpi2 commented Feb 14, 2024

This is used for session save?

Yes, I think so

@adpi2 adpi2 merged commit 749b9ca into sbt:develop Feb 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants