New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Report error if output file of a cached task is not in the output directory #7539
Conversation
This reverts commit 763383c.
bf5c53d
to
16888d2
Compare
Report a cache error if the output file of a task is not cacheable
16888d2
to
2e439ca
Compare
I am not sure why but Java Adopt 8 does not seem to be available on the latest MacOS runner anymore:
|
I guess as long as one of the tests use JDK 8 to make sure we can build, the others can use JDK 17 or whatever? |
fb35a97
to
1f07c9c
Compare
So it seems the latest MacOS runner bumped from macos-12 to macos-14-arm64 which is why Java 8 and Python 3.7 are not available anymore. I tried bumping to Java 11 and Python 3.12 but the job failed. I rolled back to macos-12 instead. |
It's ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In the
ActionCache
, we check that all output files are in the output directory. If they are not, we still run the task, but we print an error message saying that the task could not be cached. Also the cache summary details the number of errors.