Update jansi dep to match the one that's included in the jline dep #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich also allows sbt to work on ARM64 Windows without needing to specify -Djline.terminal=jline.UnsupportedTerminal
eed3si9n
approved these changes
Apr 18, 2024
|
Oh, sorry for the trouble - I've signed the CLA just now - would you be willing to recheck this PR, @eed3si9n? Thank you! |
SethTisue
approved these changes
Apr 18, 2024
|
CLA check is green now 👍 . Thank you for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows sbt to work on ARM64 Windows without needing to specify things like, e.g.
jline.terminal=jline.UnsupportedTerminalorTERM=dumb.Jline3 has been using jansi 2.4.1 since version 3.24.0 and sbt current Jline3 version is 3.24.1 (jline/jline3@0f01e4c)